Repository navigation
feat(browser): Extract XHR request instrumentation into xhrTracingIntegration - #26261
Conversation
size-limit report 📦Compared: ed36e23 (PR test merge using develop at 651378b) Against: 4202227 (develop) · base run #66528
|
Optional E2E testsSome optional checks were not successful. They do not block the merge. 1 not successful, 27 successful. See the run.
Successful checks
|
d2a1a95 to
9eb974f
Compare
9eb974f to
e53883b
Compare
|
@BugBot run |
e53883b to
54e27bf
Compare
54e27bf to
9c59c53
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 9c59c53. Configure here.
|
|
||
| expect(instrumentSpy).toHaveBeenCalledTimes(calls); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
Missing integration test coverage
Low Severity
This feat PR only adds unit tests that mock instrumentXhrRequests and check registration by name. There is no integration or E2E test for the documented browserTracingCoreIntegration() plus xhrTracingIntegration() setup. Flagged because the testing conventions require at least one integration or E2E test on feat PRs.
Additional Locations (1)
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 9c59c53. Configure here.
…tegration` `browserTracingIntegration` registers it by default, so nothing changes for its users. `browserTracingCoreIntegration` only instruments fetch, so fetch-only apps can leave XHR out of their bundle.
9c59c53 to
bead391
Compare


XHR instrumentation was always bundled. this PR moves the instrumentation to a new
xhrTracingIntegration, whichbrowserTracingIntegrationregisters by default.I added a test that it's registered unless
traceXHRis off.xhrTracingIntegrationadds ~2.3 KB gzip on top ofbrowserTracingCoreIntegration, or ~680 B whenfetchTracingIntegrationis already there, since they share the request code.